RFR: 8370123: Minor jpackage refactoring [v2]
Alexander Matveev
almatvee at openjdk.org
Tue Oct 21 00:46:02 UTC 2025
On Sat, 18 Oct 2025 04:34:54 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Minor changes, no functional impact.
>>
>> - ApplicationBuilder: add externalApplication() and mainLauncherClassName() methods
>> - `AppImageSigner.normalizeAppImageLayout()` -> `AppImageSigner.copyWithUnresolvedAppImageLayout()`
>> - Add `JLinkRuntimeBuilder.ensureBaseModuleInModulePath()`; move code away from StandardBundlerParam; remove redundant "warning.no.jdk.modules.found" string ID
>> - Add `OverridableResource.probe()` method
>> - Remove dead and "odd" code from IOUtils
>
> Alexey Semenyuk has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains nine commits:
>
> - Merge branch 'master' into JDK-8370123
> - JLinkRuntimeBuilder: remove trailing whitespace
> - JLinkRuntimeBuilder: add a comment
> - IOUtils: remove dead code; remove getFileName(), getParent() functions.
> - ApplicationLaunchers: minor
> - OverridableResource: add probe() method
> - Add JLinkRuntimeBuilder.ensureBaseModuleInModulePath()
> - AppImageSigner: better function name
> - ApplicationBuilder: add externalApplication() and mainLauncherClassName() methods
Looks good.
-------------
Marked as reviewed by almatvee (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27873#pullrequestreview-3358408932
More information about the core-libs-dev
mailing list