RFR: 8370122: jpackage test lib improvements [v4]

Alexey Semenyuk asemenyuk at openjdk.org
Wed Oct 22 02:37:59 UTC 2025


On Wed, 22 Oct 2025 01:25:57 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> Alexey Semenyuk has refreshed the contents of this pull request, and previous commits have been removed. The incremental views will show differences compared to the previous content of the PR. The pull request contains 12 new commits since the last revision:
>> 
>>  - AddLauncherTest: add test cases for the main/additional launcher descriptions
>>  - AppImagePackageTest: better logging; ObjectMapper: fix a warning
>>  - jpackage test lib: assorted improvements; LinuxHelper: validate "Comment" property of a .desktop file
>>  - IdentityWrapper: trim trailing whitespace
>>  - Move IdentityWrapper to jdk.jpackage.internal.util package for later use by CompositeProxy
>>  - ApplicationLayout: runtime layout should have a valid "runtimeHome" property
>>  - Fix the merge
>>  - LinuxHelper: revamp
>>  - AppImagePackageTest: make it produce a valid mac bundle to leverage the default verification of jpackage output in jpackage test lib.
>>  - AdditionalLauncher: make getAdditionalLauncherProperties() public; LauncherIconVerifier: make setters unambiguous; Add ConfigurationTarget
>>  - ... and 2 more: https://git.openjdk.org/jdk/compare/58f206b4...cad3e788
>
> test/jdk/tools/jpackage/helpers/jdk/jpackage/test/ObjectMapper.java line 363:
> 
>> 361:         return Collectors.toMap(keyMapper, valueMapper, (x , y) -> {
>> 362:             throw new UnsupportedOperationException(
>> 363:                     String.format("Enries with the same key and different values [%s] and [%s]", x, y));
> 
> `Enries` -> `Entries`

Fixed

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27872#discussion_r2450245079


More information about the core-libs-dev mailing list