RFR: 8368975: Windows ProcessImpl.java has dead code [v2]

Francesco Andreuzzi fandreuzzi at openjdk.org
Thu Oct 23 10:49:38 UTC 2025


On Thu, 23 Oct 2025 10:00:53 GMT, Albert Mingkun Yang <ayang at openjdk.org> wrote:

>> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   keep var
>
> src/java.base/windows/classes/java/lang/ProcessImpl.java line 431:
> 
>> 429:         final String allowAmbiguousCommands = System.getProperty("jdk.lang.Process.allowAmbiguousCommands", "true");
>> 430: 
>> 431:         if (!"false".equalsIgnoreCase(allowAmbiguousCommands)) {
> 
> I'd suggest keeping the original `boolean` var, which is more readable.

14cb92393c7bd213c98be6053df50ae1f87a75a5

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27945#discussion_r2454694452


More information about the core-libs-dev mailing list