RFR: 8368975: Windows ProcessImpl.java has dead code [v2]
Roger Riggs
rriggs at openjdk.org
Thu Oct 23 14:11:46 UTC 2025
On Thu, 23 Oct 2025 10:49:36 GMT, Francesco Andreuzzi <fandreuzzi at openjdk.org> wrote:
>> Removal of dead code in the windows flavor of `ProcessImpl.java`. The removed branches can't be reached because `allowAmbiguousCommands` is known to be `false` in the `else` block.
>>
>> Passes tier1 in GHA.
>
> Francesco Andreuzzi has updated the pull request incrementally with one additional commit since the last revision:
>
> keep var
Looks fine.
(I had decided it wasn't worth the overhead to fix it myself).
-------------
Marked as reviewed by rriggs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27945#pullrequestreview-3370156570
More information about the core-libs-dev
mailing list