RFR: 8364361: [process] java.lang.Process should implement Closeable [v18]

Joe Darcy darcy at openjdk.org
Fri Oct 24 04:37:08 UTC 2025


On Fri, 17 Oct 2025 14:39:50 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Adopt review suggestions for javadoc wording.
>   Refactor the utility method to wait for the process, return true on termination, false on interrupt.
>   Various updates to the test related to logging of output when a test fails.

src/java.base/share/classes/java/lang/Process.java line 264:

> 262:             c.close();
> 263:             return firstIOE;
> 264:         } catch (IOException ioe) {

What is the expected outcome if the close method misbehaves and throws a runtime exception or error instead of IOException?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2458842162


More information about the core-libs-dev mailing list