RFR: 8364361: [process] java.lang.Process should implement Closeable [v19]
Joe Darcy
darcy at openjdk.org
Fri Oct 24 20:58:08 UTC 2025
On Fri, 24 Oct 2025 18:07:40 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Review comment updates to handle cases where stream close methods might
> throw exceptions other then IOException and add them to the suppressed exceptions.
> Update the spec and @implSpec to be clear about exception handling
> and how the process is terminated with destroyForcibly.
Marked as reviewed by darcy (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/26649#pullrequestreview-3378814774
More information about the core-libs-dev
mailing list