RFR: 8370370: Add still more cases to WorstCaseTests [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Mon Oct 27 16:19:17 UTC 2025
On Mon, 27 Oct 2025 13:33:53 GMT, Raffaello Giulietti <rgiulietti at openjdk.org> wrote:
>> Joe Darcy has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Add more test cases.
>
> test/jdk/java/lang/Math/WorstCaseTests.java line 613:
>
>> 611:
>> 612: // Julia worst-case observed error, 1.9 ulps
>> 613: // {0x1.8633c654fee2bp-831, +0x1.fdf25fc26e7cp1023},
>
> Suggestion:
>
> // {-0x1.633c654fee2bap9, +0x1.fdf25fc26e7cp1023},
@jddarcy Can you check the discrepancy in the argument?
> test/jdk/java/lang/StrictMath/HyperbolicTests.java line 475:
>
>> 473:
>> 474: // Julia worst-case input
>> 475: {0x1.0108b83c4bbc8p-1, 0x1.dad53a45da5b0p-2},
>
> Suggestion:
>
> {0x1.0108b83c4bbc8p-1, 0x1.dad53a45da5b2p-2},
Here the difference is 2 ulps, maybe worth checking.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27939#discussion_r2466279715
PR Review Comment: https://git.openjdk.org/jdk/pull/27939#discussion_r2466282130
More information about the core-libs-dev
mailing list