RFR: 8364361: [process] java.lang.Process should implement Closeable [v22]
Roger Riggs
rriggs at openjdk.org
Mon Oct 27 17:35:11 UTC 2025
On Mon, 27 Oct 2025 16:56:21 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Corrected ProcessCloseTest to expect a racy result from "echo abc" and Process.close.
>
> src/java.base/share/classes/java/lang/Process.java line 212:
>
>> 210: * The {@code outputWriter} and {@code outputStream} to the process are closed.
>> 211: * The {@code inputReader} and {@code inputStream} from the process are closed.
>> 212: * The {@code errorReader} and {@code errorStream} from the process are closed.
>
> The implSpec is quite verbose as it lists all 6 streams and character streams. Maybe shorten to say that the method first closes all I/O streams, then waits for the process to terminate?
I expect the implSpec to be specific as to the order and enumerate the actions.
Given the detail in the rest of the javadoc, perhaps the @implSpec is redundant and unnecessary.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2466504866
More information about the core-libs-dev
mailing list