RFR: 8364361: [process] java.lang.Process should implement Closeable [v22]
Roger Riggs
rriggs at openjdk.org
Mon Oct 27 18:42:33 UTC 2025
On Mon, 27 Oct 2025 18:20:06 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> I expect the implSpec to be specific as to the order and enumerate the actions.
>> Given the detail in the rest of the javadoc, perhaps the @implSpec is redundant and unnecessary.
>
> The `Process.close()` method is not only overridable by subclasses, it is supposed to be overridden. An `@implSpec` tag is the proper mechanism to document in detail the operational semantics of `Process.close()`, including the other method of `Process` that it calls. Some of the other text describing that could be moved here.
>
> In additional, perhaps an `@apiNote` should be added to this method "hey, if you're overriding this method, make sure to call super, etc." to supplement the statement to that effect at the class-level.
Similar recommendations for other methods use @implNote.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2466698817
More information about the core-libs-dev
mailing list