RFR: 8367603: Optimize exact division in BigDecimal [v24]
fabioromano1
duke at openjdk.org
Wed Oct 29 11:52:01 UTC 2025
On Mon, 27 Oct 2025 19:50:46 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> fabioromano1 has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Respond to review feedback
>
> src/java.base/share/classes/java/math/BigDecimal.java line 1794:
>
>> 1792: if (this.signum() == 0) // 0/y
>> 1793: return zeroValueOf(preferredScale);
>> 1794: else {
>
> The old algorithm has relatively few paths through it for different arguments.
>
> Do the existing test cases provide adequate coverage of the new set of code paths?
I think they do, @rgiulietti do you think the test coverage is adequate?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27271#discussion_r2472693270
More information about the core-libs-dev
mailing list