RFR: 8364361: [process] java.lang.Process should implement Closeable [v24]

Pavel Rappo prappo at openjdk.org
Thu Oct 30 12:12:35 UTC 2025


On Mon, 27 Oct 2025 18:42:32 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Add \@implNote to recommend overriding close and calling `super.close()`.

src/java.base/share/classes/java/lang/Process.java line 188:

> 186:      * are lost, they are discarded or ignored.
> 187:      * <p>
> 188:      * If the process exit value of the process is of interest, then the caller must

Suggestion:

     * If the process exit value is of interest, then the caller must

src/java.base/share/classes/java/lang/Process.java line 203:

> 201:      * this method continues to wait for the process to terminate.
> 202:      * The interrupted status is re-asserted before this method returns and
> 203:      * any {@code IOExceptions} are thrown.

Suggestion:

     * The interrupted status is re-asserted before this method returns or
     * an {@code IOException} is thrown.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2477861213
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2477867129


More information about the core-libs-dev mailing list