RFR: 8370965: Remove SigningPackageFromTwoStepAppImageTest test

[Alexey Semenyuk]

On Thu, 30 Oct 2025 17:09:40 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

> Remove redundant SigningPackageFromTwoStepAppImageTest test.

@sashamatveev PTAL

Quote from the description of the https://github.com/openjdk/jdk/pull/10316 PR:

> Problem is that [JDK-8286850](https://bugs.openjdk.org/browse/JDK-8286850) never set correct value in .jpackage.xml to mark image as signed.

I believe the right way to test that jpackage writes correct data in the .jpackage.xml file in the two-step signing scenario is to add a relevant check to the SigningAppImageTwoStepsTest test. But it still doesn't have this check. Instead, the correctness of .jpackage.xml in the predefined app image is (was) indirectly tested in SigningPackageFromTwoStepAppImageTest test.

Even more reasons to remove SigningPackageFromTwoStepAppImageTest as it was hiding a gap in test coverage in the SigningAppImageTwoStepsTest test :)

UPD: We test the value of the "mac-signed" property in ,jpackage.xml file in [JPackageCommand.assertAppImageFile()](https://github.com/openjdk/jdk/blob/a5f3a6f21b68fe9b97cb1aa22f54173b192fbd10/test/jdk/tools/jpackage/helpers/jdk/jpackage/test/JPackageCommand.java#L1217) function. No need to update SigningAppImageTwoStepsTest test.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/28068#issuecomment-3469100761
PR Comment: https://git.openjdk.org/jdk/pull/28068#issuecomment-3470359163