RFR: 8370393: Cleanup handling of ancient Windows versions from GetJavaProperties java_props_md
Christoph Langer
clanger at openjdk.org
Fri Oct 31 09:15:06 UTC 2025
On Tue, 28 Oct 2025 15:05:14 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
> There are some ancient Windows versions still handled in GetJavaProperties :
>
> https://github.com/openjdk/jdk/blob/master/src/java.base/windows/native/libjava/java_props_md.c#L456
>
> We compile currently with Windows 8+ settings :
>
>
> # _WIN32_WINNT=0x0602 means access APIs for Windows 8 and above. See
> # https://docs.microsoft.com/en-us/cpp/porting/modifying-winver-and-win32-winnt?view=msvc-170
> ALWAYS_DEFINES="-DWIN32_LEAN_AND_MEAN -D_WIN32_WINNT=0x0602 \
>
>
> So everything older than Windows 8 could most likely be removed.
I guess this is ok now. But somebody from the platform libraries team should approve this as well.
-------------
Marked as reviewed by clanger (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/28022#pullrequestreview-3403200748
More information about the core-libs-dev
mailing list