RFR: 8366537: Test "java/util/TimeZone/DefaultTimeZoneTest.java" is not updating the zone ID as expected [v2]

Vanitha B P duke at openjdk.org
Tue Sep 2 15:50:59 UTC 2025


On Tue, 2 Sep 2025 14:35:47 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:

>> Vanitha B P has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   modified tzid variable
>
> test/jdk/java/util/TimeZone/DefaultTimeZoneTest.java line 111:
> 
>> 109:         panel.setLayout(new BoxLayout(panel, BoxLayout.PAGE_AXIS));
>> 110:         // Time zone ID label
>> 111:         var tzid = new JLabel("Time zone ID: " + SDF.getTimeZone().getID(), SwingConstants.CENTER);
> 
> minor: do you think changing it to a more intuitive `timeZoneID` would make it easier to read? If you want to leave it as is - I don't mind

Done, changed to timeZoneID.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27043#discussion_r2316501052


More information about the core-libs-dev mailing list