RFR: 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972
Naoto Sato
naoto at openjdk.org
Tue Sep 2 16:10:44 UTC 2025
On Fri, 29 Aug 2025 18:00:25 GMT, Justin Lu <jlu at openjdk.org> wrote:
> This PR addresses a JCK test failure related to `DecimalFormatSymbols` de-serialization. While the current public API of DFS disallows a null locale, it was possible to set in the past. Thus, the `loadNumberData(locale)` call currently throws NPE when locale is null in the stream. The call should be guarded with a null check, such that if locale is null, then `lenientMinusSigns` defaults to `minusSignText`.
>
> Defaulting the locale field when `null` to Locale.ROOT is also a reasonable solution, but I think that the current one is preferable as a user would not expect locale data related logic to occur if locale is `null`.
There are some tests for serializing DecimalFormatSymbols, but I agree that it would be desirable to revisit and cover missing cases.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27008#issuecomment-3245960204
More information about the core-libs-dev
mailing list