RFR: 8366401: JCK test api/java_text/DecimalFormatSymbols/serial/InputTests.html fails after JDK-8363972 [v4]

Naoto Sato naoto at openjdk.org
Tue Sep 2 22:29:41 UTC 2025


On Tue, 2 Sep 2025 21:21:04 GMT, Justin Lu <jlu at openjdk.org> wrote:

>> This PR addresses a JCK test failure related to `DecimalFormatSymbols` de-serialization. While the current public API of DFS disallows a null locale, it was possible to set in the past. Thus, the `loadNumberData(locale)` call currently throws NPE when locale is null in the stream. The call should be guarded with a null check, such that if locale is null, then `lenientMinusSigns` defaults to `minusSignText`.
>> 
>> Defaulting the locale field when `null` to Locale.ROOT is also a reasonable solution, but I think that the current one is preferable as a user would not expect locale data related logic to occur if locale is `null`.
>
> Justin Lu has updated the pull request incrementally with one additional commit since the last revision:
> 
>   public API is too broad

LGTM

-------------

Marked as reviewed by naoto (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27008#pullrequestreview-3178334115


More information about the core-libs-dev mailing list