RFR: 8077587: BigInteger Roots [v78]
Raffaello Giulietti
rgiulietti at openjdk.org
Wed Sep 3 10:00:55 UTC 2025
On Wed, 3 Sep 2025 09:47:16 GMT, fabioromano1 <duke at openjdk.org> wrote:
>> src/java.base/share/classes/java/math/MutableBigInteger.java line 2060:
>>
>>> 2058: * Instead of shifting the approximate root into the original range right now,
>>> 2059: * we only duplicate its bit length and then refine it with Newton's recurrence,
>>> 2060: * using a congruent shifted radicand, in order to avoid computing and
>>
>> Maybe clarify what "congruent" means here
>
> The way the radicand is determined is specified in the same comment below.
What I mean is that "congruent" usually has a specific mathematical meaning, which is not what is meant here, IIUC.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24898#discussion_r2318445423
More information about the core-libs-dev
mailing list