RFR: 8364361: [process] java.lang.Process should implement close and be AutoCloseable [v6]

[David Lloyd]

On Wed, 20 Aug 2025 20:43:27 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   javadoc tweaks

src/java.base/share/classes/java/lang/Process.java line 664:

> 662:             ioe = quietClose(errorReader != null ? errorReader : getErrorStream(), ioe);
> 663: 
> 664:             destroy();      // no-op if process is not alive

On some platforms, `destroy` and `destroyForcibly` behave differently. That means `close` would also behave differently depending on the platform. Maybe it should either always call `destroyForcibly` or else only call `destroy` if `supportsNormalTermination` (and otherwise hope that closing the streams is a good enough hint) to be consistent?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2319913955