Integrated: 8365428: Unclear comments on java.lang.invoke Holder classes

Chen Liang liach at openjdk.org
Fri Sep 5 15:58:20 UTC 2025


On Fri, 29 Aug 2025 19:17:23 GMT, Chen Liang <liach at openjdk.org> wrote:

> java.lang.invoke has a few Holder classes in DirectMethodHandle, DelegatingMethodHandle, Invokers, and LambdaForm.
> 
> Currently, the comments simply refer to "Placeholder for xxx generated ahead-of-time".
> 
> However, they carry executed bytecode and show up in flame graphs. The current comments are definitely not sufficient for their details and purposes.
> 
> To address these shortcomings, I improved the comments on the Holder classes and GenerateJLIClassesHelper to briefly describe the generation process. In addition, I improved the comments on BoundMethodHandle to provide a more efficient overview.

This pull request has now been integrated.

Changeset: 9f4d5b23
Author:    Chen Liang <liach at openjdk.org>
URL:       https://git.openjdk.org/jdk/commit/9f4d5b2398cb925ec1a66f9f7676b76c99ff7b62
Stats:     147 lines in 7 files changed: 109 ins; 8 del; 30 mod

8365428: Unclear comments on java.lang.invoke Holder classes

Reviewed-by: iklam, jvernee

-------------

PR: https://git.openjdk.org/jdk/pull/27010


More information about the core-libs-dev mailing list