RFR: 8365483: Test sun/rmi/runtime/Log/6409194/NoConsoleOutput.java sometimes fails [v2]
Daniel Fuchs
dfuchs at openjdk.org
Tue Sep 9 15:31:44 UTC 2025
On Tue, 9 Sep 2025 15:25:05 GMT, David Beaumont <duke at openjdk.org> wrote:
>> The writer field of the handler needs to be re-checked for null inside the locked region before use.
>
> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>
> Adding test (thanks Jai)
Thanks for adding that test @david-beaumont ! The license header needs to be fixed though.
test/jdk/java/util/logging/StreamHandlerRacyCloseTest.java line 9:
> 7: * published by the Free Software Foundation. Oracle designates this
> 8: * particular file as subject to the "Classpath" exception as provided
> 9: * by Oracle in the LICENSE file that accompanied this code.
Tests should not have the "Classpath" exception.
test/jdk/java/util/logging/StreamHandlerRacyCloseTest.java line 139:
> 137: }
> 138: }
> 139: }
Please fix newlines at the end.
-------------
Changes requested by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27173#pullrequestreview-3202149911
PR Review Comment: https://git.openjdk.org/jdk/pull/27173#discussion_r2334004641
PR Review Comment: https://git.openjdk.org/jdk/pull/27173#discussion_r2334004313
More information about the core-libs-dev
mailing list