RFR: 8342382: Implement JEP 522: G1 GC: Improve Throughput by Reducing Synchronization [v55]
Thomas Schatzl
tschatzl at openjdk.org
Wed Sep 10 11:44:34 UTC 2025
On Wed, 10 Sep 2025 09:33:42 GMT, Andrew Haley <aph at openjdk.org> wrote:
>> Thomas Schatzl has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 74 commits:
>>
>> - Merge branch 'master' into 8342382-card-table-instead-of-dcq
>> - * iwalulya: remove confusing comment
>> - * sort includes
>> - Merge branch 'master' into 8342382-card-table-instead-of-dcq
>> - * improve logging for refinement, making it similar to marking logging
>> - * commit merge changes
>> - Merge branch 'master' into 8342382-card-table-instead-of-dcq
>> - * fix merge error
>> - * forgot to actually save the files
>> - Merge branch 'master' into 8342382-card-table-instead-of-dcq
>> - ... and 64 more: https://git.openjdk.org/jdk/compare/9e3fa321...e7c3a067
>
> src/hotspot/cpu/aarch64/gc/g1/g1BarrierSetAssembler_aarch64.cpp line 95:
>
>> 93: Label loop;
>> 94: Label next;
>> 95: const Register end = count;
>
> This aliasing of register names is tricky and confusing. A trap for maintainers, of the kind that people have fallen into already.
I can argue I was following precedence :) I see your point though. What do you suggest to do here? Use `count` throughout instead?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23739#discussion_r2336468727
More information about the core-libs-dev
mailing list