RFR: 8346719: Add relaunchers to the static JDK image for missing executables
Jiangli Zhou
jiangli at openjdk.org
Thu Sep 11 00:43:17 UTC 2025
On Wed, 10 Sep 2025 12:28:43 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
>> Right now, the static-jdk image is a bit strange in that it's a modular run-time image but with all native code compiled into bin/java. In time we hope that jlink will be able to create a static image where everything is in the single executable, so no bin directory (or any directory) for launchers. I don't object to doing something to help testing the intermediate step, just not sure that main line is the right place for this.
>>
>> As regards the shim when I wonder if it should use CreateProcessW but maybe it doesn't matter for the test environments where they will run.
>
> @AlanBateman @jianglizhou Now that Erik has approved the build functionality, I'd appreciate if anyone of you could approve as well, then I can finally integrate this.
> @magicus I'll take a look today.
Hi @magicus I looked at your changes and focused on the launcher changes. I only looked quickly of the build changes, I think @erikj79's review is sufficient. For launcher changes, my main question is Windows platform support (for static JDK) and testing. The rest of the comments are minor.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24380#issuecomment-3276985687
More information about the core-libs-dev
mailing list