RFR: 8367005: ImageReader refactor caused performance regressions for startup and footprint [v2]

David Beaumont duke at openjdk.org
Thu Sep 11 10:01:30 UTC 2025


On Thu, 11 Sep 2025 03:12:33 GMT, Chen Liang <liach at openjdk.org> wrote:

>> While you are at it, both findNode and BuildModulesNode should have comments indicating that the node can be found in one of two places.
>
> If something shouldn't happen, I would prefer an explicit exception or at least an assert.

Not 100% sure it's impossible to tickle this with current callers (e.g. "jrt:/module//path" leaving the trailing path starting with a '/') so I'd rather not risk triggering IAE in existing code.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27203#discussion_r2339884131


More information about the core-libs-dev mailing list