RFR: 8367005: ImageReader refactor caused performance regressions for startup and footprint [v5]

David Beaumont duke at openjdk.org
Thu Sep 11 17:19:57 UTC 2025


On Thu, 11 Sep 2025 16:14:10 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> David Beaumont has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Removed unnecessary path check and added extra test for modules not being returned.
>
> src/java.base/share/classes/jdk/internal/jimage/ImageReader.java line 331:
> 
>> 329:                 if (name.startsWith(MODULES_ROOT + "/")) {
>> 330:                     // This may preform two lookups, one for a directory (in
>> 331:                     // /modules/...) and one for a non-prefixed resource.
> 
> Would it be possible to provide a summary on what a "non-prefixed resource" is? I realize there is comment from the previous change on this but I can't immediately see what this is.

Done.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27203#discussion_r2341844515


More information about the core-libs-dev mailing list