RFR: 8357708: com.sun.jndi.ldap.Connection ignores queued LDAP replies if Connection is subsequently closed [v4]

[Jaikiran Pai]

On Wed, 10 Sep 2025 15:18:25 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Jaikiran Pai has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains six additional commits since the last revision:
>> 
>>  - remove format() call in exception message creation
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - merge latest from master branch
>>  - add test
>>  - 8357708: com.sun.jndi.ldap.Connection ignores queued LDAP replies if Connection is subsequently closed
>
> test/jdk/javax/naming/ldap/LdapClientConnTest.java line 62:
> 
>> 60:  * @library /test/lib
>> 61:  * @build jdk.test.lib.net.URIBuilder
>> 62:  * @run junit LdapClientConnTest
> 
> Since this test creates a daemon thread and does not try to join the thread at the end it might be more prudent to run it in `/othervm` mode?

Hello Daniel, good catch. It took me a while to understand this - leaving around arbitrary test specific threads in an agent VM isn't wise. You are right, making it othervm would be better. I've updated the PR to do so.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25449#discussion_r2343177588