RFR: 8367005: ImageReader refactor caused performance regressions for startup and footprint [v6]

[David Beaumont]

On Fri, 12 Sep 2025 11:43:25 GMT, David Beaumont <duke at openjdk.org> wrote:

>> test/jdk/jdk/internal/jimage/ImageReaderTest.java line 150:
>> 
>>> 148:     @ValueSource(strings = {
>>> 149:             // Absolute resource names are not allowed.
>>> 150:             "modfoo:/com/bar/One.class",
>> 
>> JUnit jupiter also has a `CsvSource` https://docs.junit.org/current/api/org.junit.jupiter.params/org/junit/jupiter/params/provider/CsvSource.html#example-heading which allows these params to be represented individually. So something like:
>> 
>> 
>> @CsvSource ({
>> "modfoo, /com/bar/One.class",
>> "modfoo, com/foo/Alpha.class",
>> ...
>> })
>> testFindResourceNode_absent(String module, String path)
>> 
>> 
>> If you prefer it in the current form, that's fine too.
>
> Interesting, "CSV" is not where I'd have looked for that functionality.

Hmm, that syntax doesn't work for me.

org.junit.jupiter.api.extension.ParameterResolutionException: No ParameterResolver registered for parameter [java.lang.String arg1] in method [public void ImageReaderTest.testResourceNodes_present(java.lang.String,java.lang.String) throws java.io.IOException].


I'll just add the empty path case and leave it at that.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27203#discussion_r2343983393