RFR: 8367005: ImageReader refactor caused performance regressions for startup and footprint [v8]

[David Beaumont]

On Tue, 16 Sep 2025 09:59:02 GMT, David Beaumont <duke at openjdk.org> wrote:

>> If this is called with "/" in a module name then it means we've got a bug somewhere. So I think the IAE would help find that bug quicker.
>
> Fair enough. I'll look at the callers and see if there's any route by which an "invalid" module name could appear. Though I already have to assume nobody uses "modules" or "packages" as the module name.

It looks like ModuleDescriptor.Builder could be used in non-strict mode to get a module with a '/' in its name which might be passed to this code. And as this is a public class (albeit internal) it's possible someone does this.
So adding an IAE would make things blow up in a way it didn't before. I assume you're happy with this.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/27203#discussion_r2351790934