RFR: 8364361: [process] java.lang.Process should implement Closeable [v8]
Lance Andersen
lancea at openjdk.org
Tue Sep 16 16:22:21 UTC 2025
On Mon, 15 Sep 2025 19:27:18 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> Monor improvements to javadoc, move close() near the constructor
> to make it more prominent in the javadoc.
Thank you for tackling this Roger.
I think your changes are in a good place
-------------
Marked as reviewed by lancea (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26649#pullrequestreview-3230763198
More information about the core-libs-dev
mailing list