RFR: 8367859: Remove nio exception gensrc
Naoto Sato
naoto at openjdk.org
Thu Sep 18 16:20:33 UTC 2025
On Wed, 17 Sep 2025 18:57:45 GMT, Magnus Ihse Bursie <ihse at openjdk.org> wrote:
> An alternative implementation to https://github.com/openjdk/jdk/pull/27338, which removes the entire gensrc stage and instead permanently checks in the generated Java files.
charset package changes look good to me
src/java.base/share/classes/java/nio/charset/IllegalCharsetNameException.java line 30:
> 28: /**
> 29: * Unchecked exception thrown when a string that is not a
> 30: * <a href="Charset.html#names">legal charset name</a> is used as such.
Could utilize new construct as `{@linkplain Charset##names legal charset name}`
-------------
Marked as reviewed by naoto (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27352#pullrequestreview-3240774915
PR Review Comment: https://git.openjdk.org/jdk/pull/27352#discussion_r2360132337
More information about the core-libs-dev
mailing list