RFR: 8367704: Fix minor documentation issues in java.time.** [v6]
Pavel Rappo
prappo at openjdk.org
Thu Sep 18 20:55:33 UTC 2025
On Tue, 16 Sep 2025 23:14:13 GMT, Joe Darcy <darcy at openjdk.org> wrote:
>> Pavel Rappo has updated the pull request incrementally with one additional commit since the last revision:
>>
>> An empty commit to kick GHA
>
> Okay -- while some of the changes here are clearly bugs, that doesn't obviate the need for a quick CSR review.
>
> Regarding _integer_ values, 0 is conventionally neither positive nor negative; it stands alone, hence Math.signum(int):
>
> "Returns the signum function of the specified int value. (The return value is -1 if the specified value is negative; 0 if the specified value is zero; and 1 if the specified value is positive.)"
>
> Therefore, "non-negative" integers include zero while "positive" integers do not.
@jddarcy, are you okay with me pushing this without CSR? To my mind, it now contains typo fixes and editorial improvements only.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27296#issuecomment-3309694016
More information about the core-libs-dev
mailing list