RFR: 8364361: [process] java.lang.Process should implement Closeable [v9]
Alan Bateman
alanb at openjdk.org
Mon Sep 22 09:41:45 UTC 2025
On Fri, 19 Sep 2025 21:18:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:
>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>>
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>>
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
>
> The CSR review prompted the expansion of the description of responsibilities
> of subclasses of Process to invoke `super.close()` if overriding the `close()` method.
src/java.base/share/classes/java/lang/Process.java line 180:
> 178:
> 179: /**
> 180: * Close all writer and reader streams and terminate the process.
Maybe not in this PR but I think we'll have to take a pass over the Process docs so that it uses consistent terminology. Right now the class description speaks of "Destroying a process" and defines "destroy" methods to "kill" a process. The "destroyForcibly" method speaks of the process being "forcibly terminated". The update to the close method means it is specified to "terminate" a process. It just means different terms in the first sentence of method descriptions. I think we could make "terminate", "terminate forcibly", and "await termination" work.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2367302709
More information about the core-libs-dev
mailing list