RFR: 8364361: [process] java.lang.Process should implement Closeable [v9]

[Alan Bateman]

On Fri, 19 Sep 2025 21:18:03 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   The CSR review prompted the expansion of the description of responsibilities
>   of subclasses of Process to invoke `super.close()` if overriding the `close()` method.

src/java.base/share/classes/java/lang/Process.java line 172:

> 170:     private BufferedReader errorReader;
> 171:     private Charset errorCharset;
> 172:     private volatile boolean closed;     // true if close() has been called

Is volatile left over from a previous iteration? All access seems to be the synchronized close method.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2367354127