RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v2]
Alexander Matveev
almatvee at openjdk.org
Mon Sep 22 21:43:35 UTC 2025
> - Removed all code from pre- and post- installation PKG scripts.
> - This code is not needed and PKG should create destination folder and set correct permissions.
> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
> - pre- and post- installation PKG scripts are kept as empty scripts, so user can override them if needed.
> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$1` argument in scripts is same as `INSTALL_LOCATION`.
> - I think code in these scripts are some legacy leftovers.
Alexander Matveev has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
- Merge remote-tracking branch 'upstream/master' into JDK-8356047
- 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/25510/files
- new: https://git.openjdk.org/jdk/pull/25510/files/a5773744..63941ef6
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=25510&range=01
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=25510&range=00-01
Stats: 397067 lines in 6082 files changed: 274039 ins; 81749 del; 41279 mod
Patch: https://git.openjdk.org/jdk/pull/25510.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25510/head:pull/25510
PR: https://git.openjdk.org/jdk/pull/25510
More information about the core-libs-dev
mailing list