RFR: 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace [v3]

[Thomas Stuefe]

On Tue, 23 Sep 2025 14:08:35 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> 8368192: Test java/lang/ProcessBuilder/Basic.java#id0 fails with Exception: Stack trace
>> With MacOsX Sequoia 15.7 the command environment contains a new TMPDIR variable.
>> The ProcessBuild/Basic test checks for a small set of variables set in the parent
>> and ignores variables that are set by the OS or runtime, now including TMPDIR.
>> 
>> In the Basic test, for MacOSX, checks of the environment in the child should ignore TMPDIR in addition
>> to the other existing environment variables that are expected.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Simplify the code to match and remove expected environment variables on MacOSX.

Looks good. Small suggestion, up to you if you take it.

test/jdk/java/lang/ProcessBuilder/Basic.java line 801:

> 799:         // Check and remove TMPDIR
> 800:         cleanedVars = matchAndRemove(cleanedVars,
> 801:                 "TMPDIR=[^,]*,");

Why not just use reluctant match? As in `"TMPDIR=.*?,"`

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/27434#pullrequestreview-3258362224
PR Review Comment: https://git.openjdk.org/jdk/pull/27434#discussion_r2372569169