RFR: 8336695: Update Commons BCEL to Version 6.10.0

Lance Andersen lancea at openjdk.org
Wed Sep 24 12:42:44 UTC 2025


On Tue, 23 Sep 2025 21:11:07 GMT, Joe Wang <joehw at openjdk.org> wrote:

> Update Commons BCEL to Version 6.10.0.
> 
> Test: T1-3 passed

Overall, I think this is fine

Can you clarify/confirm that the comment changes are from upstream?  I commented on a couple of examples. 

Not sure why the change from "Returns" to "Gets" in several places so I am assuming this an upstream change

src/java.xml/share/classes/com/sun/org/apache/bcel/internal/Repository.java line 177:

> 175: 
> 176:     /**
> 177:      * Lookups class somewhere found on your CLASSPATH, or whereever the repository instance looks for it.

The original "wherever" is correct

src/java.xml/share/classes/com/sun/org/apache/bcel/internal/classfile/AccessFlags.java line 361:

> 359: 
> 360:     /**
> 361:      * Sets access flags also known as modifiers.

Why change here, but not other cases such as the one that follows?

-------------

PR Review: https://git.openjdk.org/jdk/pull/27459#pullrequestreview-3262626194
PR Review Comment: https://git.openjdk.org/jdk/pull/27459#discussion_r2375600253
PR Review Comment: https://git.openjdk.org/jdk/pull/27459#discussion_r2375606926


More information about the core-libs-dev mailing list