RFR: 8336695: Update Commons BCEL to Version 6.10.0
Lance Andersen
lancea at openjdk.org
Wed Sep 24 16:52:07 UTC 2025
On Wed, 24 Sep 2025 16:46:52 GMT, Joe Wang <joehw at openjdk.org> wrote:
> > Overall, I think this is fine
> > Can you clarify/confirm that the comment changes are from upstream? I commented on a couple of examples.
> > Not sure why the change from "Returns" to "Gets" in several places so I am assuming this an upstream change
>
> Yes, they are from upstream. There were 174 lines/javadoc changes for the class AccessFlags alone. I basically applied them without change, including the ones you mentioned. It's tempting to fix them, but then we'll have to re-visit them the next time we update. We used to do so. We are fortunate we haven't had to go through the exercise for the other libs as Xalan/Xerces for example, haven't had many releases in recent years.
Thank you for the clarification Joe. Just approved your PR
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27459#issuecomment-3329839342
More information about the core-libs-dev
mailing list