RFR: 8364361: [process] java.lang.Process should implement Closeable [v11]

Jason Mehrens duke at openjdk.org
Sat Sep 27 02:06:26 UTC 2025


On Mon, 22 Sep 2025 22:25:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update close() to use "terminate" consistently.

src/java.base/share/classes/java/lang/Process.java line 242:

> 240:             return firstIOE;
> 241:         } catch (IOException ioe) {
> 242:             if (firstIOE == null) {

Maybe update to:
Suggestion:

            if (firstIOE == null || firstIOE == ioe) {

To avoid edge case failure?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2383769831


More information about the core-libs-dev mailing list