RFR: 8368178: Add specialization of SequencedCollection methods to standard list factories [v3]
Tagir F. Valeev
tvaleev at openjdk.org
Sat Sep 27 05:51:00 UTC 2025
On Wed, 24 Sep 2025 23:35:16 GMT, Stuart Marks <smarks at openjdk.org> wrote:
> The reversed() overrides hardly seem worthwhile. Maybe don't include them.
Thank you. Agreed. I removed them.
> Maybe it's possible to add cases to test/jdk/java/util/Collection/MOAT.java
It's possible, but these old-style tests look fragile and less maintainable. Nevertheless, agreed, this is more consistent. I added a few new cases to MOAT.java and removed the new test classes.
> I'm also a bit surprised to see a new provider added to the ListFactories test.
I thought that we may test reversed() views thoroughly in the same way as subList() views are tested. But without reversed specializations, it looks like it's not so necessary. So I removed this provider.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/27406#issuecomment-3341261404
More information about the core-libs-dev
mailing list