RFR: 8364361: [process] java.lang.Process should implement Closeable [v11]

[Jaikiran Pai]

On Mon, 22 Sep 2025 22:25:59 GMT, Roger Riggs <rriggs at openjdk.org> wrote:

>> The teardown of a Process launched by `ProcessBuilder` includes the closing of streams and ensuring the termination of the process is the responsibility of the caller. The `Process.close()` method provides a clear and obvious way to ensure all the streams are closed and the process terminated.
>> 
>> The try-with-resources statement is frequently used to open streams and ensure they are closed on exiting the block. By implementing `AutoClosable.close()` the completeness of closing the streams and process termination can be done by try-with-resources.
>> 
>> The actions of the `close()` method are to close each stream and destroy the process if it has not terminated.
>
> Roger Riggs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update close() to use "terminate" consistently.

test/jdk/java/lang/Process/ProcessCloseTest.java line 319:

> 317:         private static void stderrExpectPolo(Process p) {
> 318:             String line = readLine(p.getErrorStream());
> 319:             Assertions.assertEquals("Polo", line, "Stderr Expected Empty");        }

This looks like a typo in the error message. I think it should be "Stderr Expected Polo".

test/jdk/java/lang/Process/ProcessCloseTest.java line 328:

> 326:         private static void stderrExpectEmpty(Process p) {
> 327:             String line = readLine(p.getErrorStream());
> 328:             Assertions.assertEquals("", line, "Stderr Expected Polo");

Typo in the error message - should have been "Stderr Expected Empty"

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2385716013
PR Review Comment: https://git.openjdk.org/jdk/pull/26649#discussion_r2385717359