RFR: 8344159: Add lint warnings for unnecessary warning suppression [v2]
Archie Cobbs
acobbs at openjdk.org
Sun Sep 28 18:56:01 UTC 2025
> This PR adds a new compiler warning for `@SuppressWarnings` annotations that don't actually suppress any warnings.
>
> Summary of code changes:
>
> * Add new warning and associated lint category `"suppression"`
> * Update `LintMapper` to keep track of which `@SuppressWarnings` suppressions have been validated ¹
> * Update `Log.warning()` so it validates any current suppression of the warning's lint category in effect.
> * Add a new `validate` parameter to `Lint.isEnabled()` and `Lint.isSuppressed()` that specifies whether to also validate any current suppression.
> * Add `Lint.isActive()` to check whether a category is enabled _or_ suppression of the category is being tracked - in other words, whether the warning calculation needs to be performed. Used for non-trivial warning calculations.
> * Add `-Xlint:-suppression` flags to `*.gmk` build files so the build doesn't break
>
> ¹ The suppression of a lint category is "validated" as soon as it suppresses some warning in that category
Archie Cobbs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 131 commits:
- Merge branch 'master' into JDK-8344159 to fix conflicts.
- Add clarifying comment.
- Merge branch 'master' into JDK-8344159
- Change inner class name to avoid shadowing superclass name.
- Add a couple of code clarification comments.
- Refactor test to avoid requiring changes to TestRunner.
- Remove unnecessary -Xlint:-suppression flags.
- Minor cleanups.
- Add OPTIONS, PATH, and SUPPRESSION to the regression test.
- Minor regression test cleanups.
- ... and 121 more: https://git.openjdk.org/jdk/compare/9093d3a0...7714095d
-------------
Changes: https://git.openjdk.org/jdk/pull/25167/files
Webrev: https://webrevs.openjdk.org/?repo=jdk&pr=25167&range=01
Stats: 1658 lines in 33 files changed: 1485 ins; 49 del; 124 mod
Patch: https://git.openjdk.org/jdk/pull/25167.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/25167/head:pull/25167
PR: https://git.openjdk.org/jdk/pull/25167
More information about the core-libs-dev
mailing list