RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v4]

[Alexey Semenyuk]

On Sat, 27 Sep 2025 02:30:13 GMT, Alexander Matveev <almatvee at openjdk.org> wrote:

>> - Removed pre- and post- installation PKG scripts.
>> - This code is not needed and PKG should create destination folder and set correct permissions.
>> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
>> - Users will have ability to provide pre- and post- installation PKG scripts if needed.
>> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$1` argument in scripts is same as `INSTALL_LOCATION`.
>> - I think code in these scripts are some legacy leftovers.
>> - Added test to test that pre- and post-scripts are no longer exist and can be added via `--resource-dir`.
>
> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
> 
>   8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v3]

src/jdk.jpackage/unix/classes/jdk/jpackage/internal/ShellScriptResource.java line 49:

> 47:             return;
> 48:         }
> 49: 

As you have already touched this file, please add a missing `private` modifier to the `final Path publicFileName` field at line 75

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2388309754