RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v4]

Alexander Matveev almatvee at openjdk.org
Mon Sep 29 16:33:17 UTC 2025


On Mon, 29 Sep 2025 14:51:06 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> It is undocumented. To keep it we need to document it first. I do not like idea to keep undocumented variables. Also, `$1` can be used instead of in the scripts. It will only break if application is generated with jpackage which contains this fix and in this case user can update scripts if needed.
>
> Even though it is undocumented, somebody might have used it for years when jpackage was a part of JavaFX.
> 
>> $1 can be used instead of in the scripts
> 
> Is `$1` a synonym for `INSTALL_LOCATION` or `APP_LOCATION`?

`$0`: The full path to the script itself.
`$1`: The full path to the installation package (.pkg file).
`$2`: The full path to the installation destination.
`$3`: The mount point of the destination volume.

This is what is available from script. It is actually `$2` which will point to install location such as `/Applications`. `APP_LOCATION` can be figured out based on application name, since it is know by user.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25510#discussion_r2388572301


More information about the core-libs-dev mailing list