RFR: 8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v5]

Alexander Matveev almatvee at openjdk.org
Mon Sep 29 21:48:23 UTC 2025


> - Removed pre- and post- installation PKG scripts.
> - This code is not needed and PKG should create destination folder and set correct permissions.
> - If for some reason it is not happens, permissions issues should be fixed when jpackage prepares application bundle. PKG should keep all permissions unchanged when packaging and installing bundle.
> - Users will have ability to provide pre- and post- installation PKG scripts if needed.
> - `INSTALL_LOCATION` and `APP_LOCATION` substitution is removed, since `$2` argument in scripts is same as `INSTALL_LOCATION`.
> - I think code in these scripts are some legacy leftovers.
> - Added test to test that pre- and post-scripts are no longer exist and can be added via `--resource-dir`.

Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:

  8356047: [macos] jpackage produces confusing post- and pre- installation PKG scripts [v4]

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/25510/files
  - new: https://git.openjdk.org/jdk/pull/25510/files/aff2544f..38da308c

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=25510&range=04
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=25510&range=03-04

  Stats: 24 lines in 3 files changed: 11 ins; 5 del; 8 mod
  Patch: https://git.openjdk.org/jdk/pull/25510.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/25510/head:pull/25510

PR: https://git.openjdk.org/jdk/pull/25510


More information about the core-libs-dev mailing list