RFR: 8362598: [macos] Add tests for custom info plist files
Alexander Matveev
almatvee at openjdk.org
Mon Sep 29 23:44:06 UTC 2025
On Fri, 26 Sep 2025 11:22:48 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> - Added test for custom info plist to cover app image including embedded runtime and runtime installer.
>> - Fixed bug in `writePList`. It was missing `writeStartDocument()/writeEndDocument()` and `DOCTYPE` should be full xml string.
>
> src/jdk.jpackage/macosx/classes/jdk/jpackage/internal/util/PListWriter.java line 93:
>
>> 91: public static void writePList(XMLStreamWriter xml, XmlConsumer content)
>> 92: throws XMLStreamException, IOException {
>> 93: xml.writeStartDocument();
>
> Why do we need `writeStartDocument()/writeEndDocument()` calls?
To write XML declaration to Info.plist file. Without it reading PList file fails.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/27509#discussion_r2389512578
More information about the core-libs-dev
mailing list