RFR: 8353835: Implement JEP 500: Prepare to Make Final Mean Final [v4]

Alan Bateman alanb at openjdk.org
Tue Sep 30 11:40:58 UTC 2025


On Mon, 29 Sep 2025 19:01:28 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Alan Bateman has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   RemoveFields(duration) and filter internal frames
>
> test/jdk/java/lang/reflect/Field/mutateFinals/modules/m1/p1/TestMain.java line 88:
> 
>> 86:             return mutators.stream();
>> 87:         }
>> 88:     }
> 
> You can consider populating `mutators` and `deniedMutators` in `setup()` using a single loop. This would result in less LoC and render `allowedToMutate` field redundant.

It doesn't really matter but it might be a bit cleaner to have "setup" locate/load the Mutators, then there would only be one place that uses ServiceLoader.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25115#discussion_r2391069760


More information about the core-libs-dev mailing list