RFR: 8368968: FloatingDecimal: Clean up unused code [v2]
Raffaello Giulietti
rgiulietti at openjdk.org
Tue Sep 30 19:17:38 UTC 2025
On Tue, 30 Sep 2025 18:42:59 GMT, Johannes Graham <duke at openjdk.org> wrote:
>> This is a followup to https://github.com/openjdk/jdk/pull/27118, to clean up resulting unused code.
>> - remove `getChars`, `isExceptional` and `isNegative`
>> - remove `ExceptionalBinaryToASCIIBuffer`; throws `IllegalArgumentException` instead of returning an instance of that.(Caller already asserts non-exceptional arg)
>
> Johannes Graham has updated the pull request incrementally with one additional commit since the last revision:
>
> Update src/java.base/share/classes/jdk/internal/math/FloatingDecimal.java
>
> Co-authored-by: Raffaello Giulietti <raffaello.giulietti at oracle.com>
Looks fine.
Thanks @j3graham for the quick turnaround.
-------------
Marked as reviewed by rgiulietti (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/27581#pullrequestreview-3286387809
More information about the core-libs-dev
mailing list