RFR: 8368825: Change the DateTimeFormatterBuilder::FIELD_MAP type from Map to Array [v3]
Chen Liang
liach at openjdk.org
Tue Sep 30 23:16:09 UTC 2025
On Tue, 30 Sep 2025 23:00:21 GMT, Shaojin Wen <swen at openjdk.org> wrote:
>> The DateTimeFormatterBuilder::FIELD_MAP is of type Map<Character, TemporalField>, with key values in the range 'A-Z' and 'a-z'.
>>
>> We can change the type of FIELD_MAP to an array of length 128 and then use char as an index to access the array.
>>
>> This will reduce the memory usage of DateTimeFormatterBuilder::FIELD_MAP and improve performance slightly.
>>
>> By analyzing the jmap dump memory, we can see that the memory size used by DateTimeFormatterBuilder::FIELD_MAP has dropped from 1.12kb to 528b, the number of objects has decreased and the memory has become more flat. as shown below:
>> * before
>> <img width="2018" height="1016" alt="image" src="https://github.com/user-attachments/assets/57d4c513-55c7-472e-95a8-9f7a4b47662d" />
>>
>> * after
>> <img width="1894" height="352" alt="image" src="https://github.com/user-attachments/assets/89cbfb6c-360a-475f-85ea-4365d3b66871" />
>
> Shaojin Wen has updated the pull request incrementally with one additional commit since the last revision:
>
> revert comment & remove unused import, from @natoj
src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java line 2193:
> 2191: */
> 2192: private static TemporalField getField(char ch) {
> 2193: return switch (ch) {
Please restore the comment
// SDF = SimpleDateFormat
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/26634#discussion_r2393030741
More information about the core-libs-dev
mailing list