RFR: 8376703: Some coding in libjimage seems to be not called at all or not called from PRODUCT code [v2]
David Beaumont
duke at openjdk.org
Mon Feb 2 10:56:50 UTC 2026
On Fri, 30 Jan 2026 12:41:33 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> libjimage has a few unused functions/methods; those are listed when logging elimination with -Wl,--gc-sections -Wl,--print-gc-sections .
>> We could remove them (or with if are still needed for completeness put them into #if 0 ) to reduce lib size on Linux and AIX.
>> On Windows and macOS it seems the compiler/linker default settings are good enough to eliminate the code.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust COPYRIGHT headers
Hi Matthias,
As luck would have it I'm also about to make some substantive changes to this code (based on Valhalla work).
These changes also remove most of the same dead-code you've identified, but I'd need to check that your work doesn't muddle my integration (see draft PR at):
https://github.com/openjdk/jdk/pull/29414/changes#diff-aa601f760164d2f192a65e314d0c29224d4e812f492094aeb4fbc8be95d0b853
I'm happy to roll in any additional dead code you've identified into my PR if that makes things easier.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/29502#issuecomment-3834397108
More information about the core-libs-dev
mailing list