RFR: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]
Alexander Matveev
almatvee at openjdk.org
Wed Feb 4 00:28:12 UTC 2026
On Mon, 2 Feb 2026 20:16:01 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:
>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>>
>> 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]
>
> src/jdk.jpackage/share/classes/jdk/jpackage/internal/util/RuntimeImageUtils.java line 47:
>
>> 45: }
>> 46:
>> 47: return releaseFile;
>
> Why do we need platform-specificity in this function?
>
> Shouldn't it be as simple as:
>
> public static Path getReleaseFilePath(Path runtimePath) {
> return runtimePath.resolve("release");
> }
This function is being called 3 times already. I think having platform specific code in it is better, then duplicating:
RuntimeImageUtils.getReleaseFilePath(MacBundle.fromPath(cookedRuntime).map(MacBundle::homeDir).orElse(cookedRuntime));
I do like idea of using `MacBundle.fromPath()`.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2761617991
More information about the core-libs-dev
mailing list