RFR: 8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]

Alexander Matveev almatvee at openjdk.org
Wed Feb 4 03:39:15 UTC 2026


On Wed, 4 Feb 2026 03:24:39 GMT, Alexey Semenyuk <asemenyuk at openjdk.org> wrote:

>> Alexander Matveev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   8357404: jpackage should attempt to get a package version from the JDK's release file if the --version option is not specified [v6]
>
> test/jdk/tools/jpackage/junit/share/jdk.jpackage/jdk/jpackage/internal/util/RuntimeVersionReaderTest.java line 44:
> 
>> 42: 
>> 43:     @Test
>> 44:     public void test_release_file_with_version(@TempDir Path workdir) {
> 
> Should we test other values of the "JAVA_VERSION" property? Empty one, some unexpected one, like "foo"?

Not as part of `RuntimeVersionReaderTest`. `RuntimeVersionReader` just read version as is, so not sure what such testing will test. Such testing should be done as part of `RuntimePackageTest`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/29260#discussion_r2762012278


More information about the core-libs-dev mailing list